kurotu / VRCQuestTools

Unity editor extension to support uploading VRChat avatars for Oculus Quest
https://kurotu.github.io/VRCQuestTools/
MIT License
207 stars 15 forks source link

issues since recent changes #5

Closed SDUBZ closed 2 years ago

SDUBZ commented 2 years ago

skin on quest side coming out diff colours like gold or green metallic toggles etc coming out wrong or not working at all not asure whats causing this since ive used all these methods before with no problems only started happening recently

kurotu commented 2 years ago

Recently v1.1.0 has changed some code structures but I believe their logic are same.

Please make sure following points:

If these don't make sense, would you provide screenshots and sample materials to inspect the issue? To be honest, I couldn't understand what is actually happening in your Unity scene.

SDUBZ commented 2 years ago

i always have remove vertex colours on textures seem correct in the generated i cant send screenshots since im not on quest i will get a zip of the avatar made by quest tools to see if you can maybe understand what is happening for this to appear the way it is for quest users

kurotu commented 2 years ago

Sounds good. I’ll check your zip.

SDUBZ commented 2 years ago

Jasmine.zip

kurotu commented 2 years ago

The zip doesn't have fbx, so I can't check the result. At least, I need a screenshot of Unity in order to know your expected result.

By the way, following typical practices may help you.

kurotu commented 2 years ago

I hid previous comment because of some issues. PLEASE delete it from the online storage.


The issue is caused by Skin Colors animation of FX layer. Unexpectedly Poiyomi materials are used on Quest. Poiyomi doesn't work well for Quest, so it makes wrong skin appearance.

VRCQuestTools converts animation clips which change materials, but BlendTrees not. So the issue happens. For right now, you need to edit animation clips or materials to be changed by FX layer.

kurotu commented 2 years ago

I made a test version of VRCQuestTools and believe this properly converts blend trees. You can download it from Artifacts section of following link. Would you try it? https://github.com/kurotu/VRCQuestTools/actions/runs/1490647673

SDUBZ commented 2 years ago

I made a test version of VRCQuestTools and believe this properly converts blend trees. You can download it from Artifacts section of following link. Would you try it? https://github.com/kurotu/VRCQuestTools/actions/runs/1490647673

yes i will do a conversion and see if one of my quest friends can say if its fixed or not

this happend in unity image

kurotu commented 2 years ago

Sorry, I missed some points.

  1. Test version had a small bug. Please use this link instead. https://github.com/kurotu/VRCQuestTools/actions/runs/1499470936
  2. Please remove Assets\KRT\VRCQuestTools then import the test version because the old v0.7.0 is used in your project.
  3. Perhaps you need to remove Assets\KRT\VRCQuestTools\Tests after importing. Somehow your project doesn't have some components such as NUnit. Tests folder is not needed at runtime.
  4. Your avatar originally had missing materials (hair, corset and pants). This is a project specific issue, so I can't help. Please focus on body skin color at this time.
  5. As written on the converter window, Poiyomi is not supported. So I can't assure about output textures.
SDUBZ commented 2 years ago

my friend said the skin textures look good my friend said on quest