search

kvj / hass_nuki_ng

Better support for Nuki devices in the Home Assistant
MIT License
177 stars 34 forks source link

Add logo and icon for dark background #20

Closed kongo09 closed 2 years ago

kongo09 commented 2 years ago

Currently, the integration uses the original Nuki logo as logo and icon: https://github.com/home-assistant/brands/tree/master/custom_integrations/nuki_ng

It is difficult to see this in dark themes: image

HA allows to provide images optimized for dark background: https://github.com/home-assistant/brands#image-specification

I propose to find/design and add these.

kongo09 commented 2 years ago

Nuki itself is using this icon for its Android app:

image

Source: https://play.google.com/store/apps/details?id=io.nuki

kongo09 commented 2 years ago

To facilitate the discussion, I've prepared the relevant variants of the icon

256 x 256 dark white
not transparent bl_nuki nuki
transparent tr_bl_nuki tr_nuki

Plus the same in high resolution 512 x 512

bl_nuki@2x

nuki@2x

tr_bl_nuki@2x

tr_nuki@2x

kongo09 commented 2 years ago

Personally, I would opt for the non-transparent white version for both, dark and light themes. That would be consistent with the Nuki app and due to the contrast it is visible in both themes.

@alexdelprete What do you think? Didn't you do the first version that's uploaded?

alexdelprete commented 2 years ago

What do you think? Didn't you do the first version that's uploaded?

I simply duplicated the official integration folder.

Frankly, I don't like that circle, I prefer the Nuki logo as it is, but I agree it's not much visible, maybe we can work on making it more visible? But I prefer the Nuki with letters and the yellow dot. But that's just my personal preference. :)

Thanks for all you're doing, I really appreciate your contributions and help.

kongo09 commented 2 years ago

As you guys prefer the logo also for the icons, I've submitted dark theme variants for the logos, but not for the circle icons.

https://github.com/home-assistant/brands/pull/3072