search

kwi / i18n_routing

I18n routing module for Rails 2.3.x and Rails 3. Translate your routes with ease !
MIT License
228 stars 48 forks source link

Scope translation in Rails.version > 3 #18

Closed SweeD closed 13 years ago

SweeD commented 13 years ago

Hi kiwi,

I've fixed this issue:

https://github.com/kwi/i18n_routing/issues/14

Greetz Markus

kwi commented 13 years ago

Thanks a lots for doing that, but can you add tests for it if you want me to pull it ?

SweeD commented 13 years ago

Oh, sorry!

Forgot to commit/push... :D Now, it's complete.

Greetz Markus

SweeD commented 13 years ago

Do you need anything else for accepting this pull request?

Greetz Markus

kwi commented 13 years ago

Yes, just need some time to pull this correctly and deploy a new version, will do this soon :/ sorry for the delay and thanks again for the pull !

kwi commented 13 years ago

Hey I finally got the time to work on it :) It's merged ! I may change a few things and push a new version :) I also need to check as I don't think the gem is compatible with Rails 3.1

Thanks !

kwi commented 13 years ago

Ah, and this doesn't work with resources or deep scoping :)