kwi / i18n_routing

I18n routing module for Rails 2.3.x and Rails 3. Translate your routes with ease !
MIT License
228 stars 48 forks source link

Alternative 'match' syntax. #22

Closed toXXIc closed 13 years ago

toXXIc commented 13 years ago

Hi. I've implemented alternative syntax for match method in Rails 3 routes mapper. By default i18n_routing was processing only match with the next syntax:

# Parameter :as required even if it's the same as mapped path.
match 'about' => 'pages#about', :as => 'about' 

Now it's possible to use alternative syntax and it will be handled and translated:

# Now :as parameter is optional and taken from path parameter if omitted.
match 'about', :to => 'pages#about'  # The same as previous route
kwi commented 13 years ago

Nice, thanks dude ! I will merge this pretty soon (As soon as I get a moment!)

2011/9/7 toXXIc < reply@reply.github.com>

Hi. I've implemented alternative syntax for match method in Rails 3 routes mapper. By default i18n_routing was processing only match with the next syntax:

Parameter :as required even if it's the same as mapped path.

match 'about' => 'pages#about', :as => 'about'

Now it's possible to use alternative syntax and it will be handled and translated:

Now :as parameter is optional and taken from path parameter if

omitted. match 'about', :to => 'pages#about' # The same as previous route

You can merge this Pull Request by running:

git pull https://github.com/toXXIc/i18n_routing master

Or you can view, comment on it, or merge it online at:

https://github.com/kwi/i18n_routing/pull/22

-- Commit Summary --

  • Another 'match' syntax is added for Rails 3.

-- File Changes --

M Gemfile (2) M Gemfile.lock (96) M lib/i18n_routing_rails3.rb (50) M spec/i18n_routing/i18n_spec.rb (25) M spec/locales/en.yml (2) M spec/locales/fr.yml (2) M spec/locales/pt-br.yml (2)

-- Patch Links --

https://github.com/kwi/i18n_routing/pull/22.patch https://github.com/kwi/i18n_routing/pull/22.diff

Reply to this email directly or view it on GitHub: https://github.com/kwi/i18n_routing/pull/22

kwi commented 13 years ago

I'm merging it and releasing a new version, thanks a lot!

toXXIc commented 13 years ago

Good news!) Thanks)