kwindrem / GuiMods

VenusOS GUI enhancements and modifications
190 stars 25 forks source link

Hide Inverter #253

Closed kuhnboy closed 3 weeks ago

kuhnboy commented 3 weeks ago

I have a 48v/12v setup where I have all of my inverting and ac loads on the 48v side with a Cerbo gx. I’d love to either:

or

kwindrem commented 3 weeks ago

I'm not sure about #1.

Some tiles hide based on presence of the related component but others like the inverter do not.

kuhnboy commented 3 weeks ago

@kwindrem do you have contribution guidelines and/or accept pull requests? image

kwindrem commented 3 weeks ago

I don't have any formal contribution guidelines but others do occasionally submit revisions via pull requests. Generally, they miss things like compatibility back to v2.7x and/or a version number change. So I've been manually incorporating their changes into my repo and rejecting the pull request.

I do have a document describing how to author a new package suitable for SetupHelper:

https://www.dropbox.com/scl/fo/bx5aftvgrqq0vp060mwip/ANKdSqoEP9MC06R-rUoIExQ?rlkey=razevzfts259w2v2r9ajeet2g&st=w2bkepz3&dl=0

It seems like you've been able to make the changes you need for your specific needs and I probably would not be inclined to incorporate them into Gui Mods.

The document I linked above describes how SetupHelper / PackageManager deals with reinstalling mods after a firmware update which might be useful to you. Or you could create a package for your personal use.

kuhnboy commented 3 weeks ago

Thanks for the response. If you feel that a 'Hide AC System' toggle does not align with guimods, then I'm fine creating my own package. I know there have been some others around the community that have asked for this, so it's not unique, but may not be a great fit for guimods so I would defer to you on that guidance. Thanks!

kwindrem commented 3 weeks ago

I made a few minor tweaks to the code and was able to hide the multi tile and the connections without any additional user preferences. I'll incorporate these changes in GuiMods

GuiMods simple flow overview

Screenshot 2024-06-13 at 11 08 08 AM

GuiMods DC & AC coupled overview

Screenshot 2024-06-13 at 11 07 48 AM
kwindrem commented 3 weeks ago

v10.39 has these changes

kuhnboy commented 3 weeks ago

Excellent. I can't wait to try this out.