search

kyagi / shell-pop-el

shell-pop.el helps you to use shell easily on Emacs. Only one key action to work.
212 stars 21 forks source link

shell-pop breaks list-registers #53

Closed wginolas closed 7 years ago

wginolas commented 7 years ago

Hi,

shell-pop uses a keyword symbol as register name (https://github.com/kyagi/shell-pop-el/blob/master/shell-pop.el#L308). This breaks list-register which tries to sort the registers by name.

sort: Wrong type argument: number-or-marker-p, :shell-pop

The docstring of register-alist states that only characters are allowed as register names.

syohex commented 7 years ago

I have sent PR about replacing using register implementation at #54.

wginolas commented 7 years ago

That was fast! Thank you very much!

syohex commented 7 years ago

Merged #54.