Open kylebarron opened 2 years ago
@kylebarron I don't have particularly strong feelings on these. Of course I have peeves about formatting but I'm self-aware in that I know they're subjective (and inconsistent Un_n).
pyupgrade
seems like a good idea.black
looks good; I would assume moving from YAPF won't be hard.isort
seems fine—I reckon consistency matters more than the actual choices in this case.click
seems nice (I think I have a memory of argparse
being annoying to work around when doing the magics but not 100%). I have mixed feelings on static typing for python. In general I'm quite happy for languages to have static types (or optional static types, like with Julia). In Python's case the interpreter ignores it, AFAIK, which makes me sad ):
So if there's a situation where typing matters the check has to be added by the programmer. While mypy
sounds like a good idea nonetheless, I guess it's hard for me to be excited about it when a) I haven't seen it in action and, more importantly, b) migrating to static typing seems by far to be the most labor-intensive bullet point.
I don't have a ton of free time at the moment, but here are some (opinionated) suggestions for making the repo easier to maintain in the future. Take these as suggestions to be discussed