Test the `kyma alpha add` command

kyma-project / cli

Simple set of commands to manage a Kyma installation

Apache License 2.0

112 stars 119 forks source link

Test the `kyma alpha add` command #2201

Closed Cortey closed 3 months ago

Cortey commented 4 months ago

Description

Changes proposed in this pull request:

rework command args
move most of the code from the cmd package to the separated place
test command code

Related issue(s)

https://github.com/kyma-project/cli/issues/2083

kyma-bot commented 4 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

Cortey commented 4 months ago

Feature was tested using short script

k3d cluster create cluster-tests

go run main.go alpha add --module api-gateway,application-connector,btp-operator,docker-registry,eventing,istio,keda,nats,serverless,telemetry

go run main.go alpha modules --installed

k3d cluster delete cluster-tests

All modules installed successfully except for : transparent proxy, cluster-ip, cap-operator which are logged as separate draft-issue

pPrecel commented 3 months ago

Works superb! Besides two minor things (2 questions) I have another question: Why we need to pass args like this: keda,nats not like: keda, nats? It's because of how Cobra work, isn't it?

Yes, it's cobra's thingy