search

kypvalanx / Foundry-VTT-StarWars-SagaEdition

25 stars 7 forks source link

add_initial_character_typedatamodel_files #463

Closed TalonKetupa closed 4 months ago

TalonKetupa commented 4 months ago

These are the inital Typedatamodel files for the character actor type. See #446

These changes are not activated yet within the code and will not currently have any effects on running systems.

kypvalanx commented 4 months ago

I'm going to merge this and start integrating it since i have a little time today.

TalonKetupa commented 4 months ago

There's actually alot of integration work to get this working. I have a large number of saved integration changes that I have saved for my testing, so really I have done most of the work already. If you want to hold off until I get through the npc section, I will be able to add the integration changes I have worked on. It might be difficult to see what this structure is doing without the rest of my changes.

At least one major change will be the way that the actor sheet updates data. Currently, it looks to be writing everything back to the database constantly which is not great. The changes here will require it to only be adjusting sheet data and writing back to the source only specific source data when required. The typedatamodel represents the source data. Derived data will not be saved in the database.

Also I already have adjustments I am making to these added files as a result of npcs and/or manual actor data.

TalonKetupa commented 4 months ago

Since this is going to be more of an overhaul than an enhancement, is there a way we can collaborate on these changes easier? A separate branch just for this feature work perhaps? I want to add in all the integration changes I have saved, but I do not want to disrupt the main branch with them as this change if not fleshed out well will CERTAINLY cause issues, and I still want you to be able to track and see and possibly edit or suggest better ways to do some of these changes.

On Tue, Apr 23, 2024, 7:51 AM kypvalanx @.***> wrote:

Merged #463 https://github.com/kypvalanx/Foundry-VTT-StarWars-SagaEdition/pull/463 into main.

— Reply to this email directly, view it on GitHub https://github.com/kypvalanx/Foundry-VTT-StarWars-SagaEdition/pull/463#event-12575122670, or unsubscribe https://github.com/notifications/unsubscribe-auth/AUQKZNIHOMRU6J45MHBKK63Y6ZKMBAVCNFSM6AAAAABGP3Z7K2VHI2DSMVQWIX3LMV45UABCJFZXG5LFIV3GK3TUJZXXI2LGNFRWC5DJN5XDWMJSGU3TKMJSGI3DOMA . You are receiving this because you authored the thread.Message ID: <kypvalanx/Foundry-VTT-StarWars-SagaEdition/pull/463/issue_event/12575122670 @github.com>