kyranstar / Hunt-The-Wumpus

6 stars 0 forks source link

Cave generation throwing assertion errors #39

Closed WasabiFan closed 9 years ago

WasabiFan commented 9 years ago

As I am debugging our game, I am repeatedly hitting debug error dialogs because assertions are failing in the cave generator. I think that we should replace these debug assertions with error/warning logging so that we don't show the judges a big error dialog when we start the game. I think it would be easiest to define an Assert method in our Log class that perforns the same core function as Debug.Assert but just logs instead of MessageBoxes.

nikbyk commented 9 years ago

That's a good idea, thought it was just me

Sent by Outlook for Android

On Fri, May 22, 2015 at 11:42 PM -0700, "Wasabi Fan" notifications@github.com wrote: As I am debugging our game, I am repeatedly hitting debug error dialogs because assertions are failing in the cave generator. I think that we should replace these debug assertions with error/warning logging so that we don't show the judges a big error dialog when we start the game. I think it would be easiest to define an Assert method in our Log class that perforns the same core function as Debug.Assert but just logs instead of MessageBoxes.


Reply to this email directly or view it on GitHub: https://github.com/kyranstar/Hunt-The-Wumpus/issues/39

kyranstar commented 9 years ago

Is it just the cave wrapping that's throwing errors?

WasabiFan commented 9 years ago

It was in MapGenerator line 184, I think.

kyranstar commented 9 years ago

Okay. Well since I commented out the AddSideConnections method we can probably close this issue