Change handle_packet_in method behavior

kytos / of_l2ls

Kytos Layer2 Learning Switch Napp

MIT License

0 stars 12 forks source link

Change handle_packet_in method behavior #19

Closed gleybersonandrade closed 3 years ago

gleybersonandrade commented 4 years ago

This PR changes handle_packet_in method to check if the ports inside actions list aren't disable from 'config' field (i.e.: OFPPC_NO_FWD flag) when sending a packet_out message.

Fix kytos/of_core#79

gleybersonandrade commented 4 years ago

Couldn't the check be in _create_packet_out?

It can be, it's really better. I'll change this.

Thanks @ajoaoff

italovalcy commented 4 years ago

Hi guys,

The patch seems to be very good for me, except for the lack of logs, exceptions, or any other information that could help the kytos user to know that the packet_out is not being sent due to the port disable. Don't you guys think it should register a log event saying the packet_out was not sent and why? Especially here: https://github.com/kytos/of_l2ls/pull/19/files#diff-5bc02cefb3ea9e27f1a6776eabd1935dR133-R135

hdiogenes commented 3 years ago

Superseded by #21.