kyueran / pe

0 stars 0 forks source link

The advance command successfully executes should be combined #15

Open kyueran opened 1 year ago

kyueran commented 1 year ago

Currently the advance command successfully executes is separated for the case of SHORTLISTED and APPLIED but the two paths could be joined at the end with a diamond to show if no error message then the command will successfully execute in line with the UML diagrams we learned.

This will make it much clearer that it is the success scenario.

Screenshot 2023-04-14 at 3.26.06 PM.png

soc-se-bot commented 1 year ago

Team's Response

Valid point to help improve the readability of the diagram but this is not an issue with the functioning of the command.

Putting not in scope to give you marks!

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: It is taught to us that we should have the different branches in our path join back together for our activity diagram and we arrive at the final result. If you refer to the activity diagrams in our textbook, all of them have 1 start and 1 end, and in your case you can definitely join the paths together to arrive at the final successful execution.

I disagree and believe that severity.Low and type.DocumentationBug is reasonable.


## :question: Issue severity Team chose [`severity.VeryLow`] Originally [`severity.Low`] - [x] I disagree **Reason for disagreement:** It is taught to us that we should have the different branches in our path join back together for our activity diagram and we arrive at the final result. If you refer to the activity diagrams in our textbook, all of them have 1 start and 1 end, and in your case you can definitely join the paths together to arrive at the final successful execution. I disagree and believe that severity.Low and type.DocumentationBug is reasonable.