kyueran / pe

0 stars 0 forks source link

Duplicate with different name case sensitivity allowed #4

Open kyueran opened 1 year ago

kyueran commented 1 year ago

Steps to reproduce: Alex Yeoh already exists in the database, add alex yeoh with the same exact email, address, phone number

Expected: Duplicate detected, not allow to add

Actual: Added as separate person

For more detail, please refer to the screenshot below:

Screenshot 2023-04-14 at 2.22.17 PM.png

From CS2103T website: Duplicate detection.png

soc-pe-bot commented 1 year ago

Team's Response

Under our Applicant's definition, name and phone number are case sensitive.

In our add command we also gave an example that "thomas" and "Thomas" are different.

Hence, alex yeoh and Alex Yeoh will be treated as separate individuals in our application

Screenshot 2023-04-16 at 9.54.36 AM.png

Screenshot 2023-04-16 at 9.53.25 AM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: While it is stated that the name is case sensitive, your UG also states that you cannot add two or more applicants with the same name and phone number. I quoted directly from the CS2103T website that this constitutes a Duplicate Detection bug. The CS2103T website clearly states that "John Doe" and "john doe" are likely to be the same person and there are no other duplicate detection mechanism within this application, thus it should be a medium featureflaw.

Duplicate detection.png

In the screenshot provided, it is clearly a problem for us to be able to input alex yeoh and Alex Yeoh with the same phone number, address and email. They should be treated as the same person.