kyueran / pe

0 stars 0 forks source link

Duplicate detection does not handle same phone number, address, email #7

Open kyueran opened 1 year ago

kyueran commented 1 year ago

This is different from the name with different case sensitivity bug as the name now is different, with different letters. The application should at least warn the user about inserting new applicant with same phone number, email, address even if they have very different names, as the person using the app might be typing in the wrong name from the wrong file accidentally. I used similar names just to make sure they show up beside each other to take a screenshot but in the case of very different names, if the person is added wrongly it could be hard to find the error.

Steps to reproduce: Add 2 people with same phone number, email, address but with different names

Expected: Same phone number detected, give warning are you sure these are two different people?

Actual: Allows two individuals with same phone number address email to be added

For more detail, please refer to the screenshot below:

Screenshot 2023-04-14 at 2.35.22 PM.png

nus-pe-script commented 1 year ago

Team's Response

According to the UG, applicants are duplicates if they have both the same name and phone number. Hence it is a valid outcome for the applicant.

Severity is low as it only happens for rare cases.

This is also in our planned iterations in our DG.

Screenshot 2023-04-16 at 10.10.13 AM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I do not agree that simply using name and phone number is good enough to identify duplicates. As shown in the screenshot in my bug, the two applicants have same phone number, address and email but have different names. Just because of difference in name, they are treated differently, this error could occur if the user input the details of an application but misspelt the name.

I believe a simple fix would be to use NRIC as a unique identifier instead which is within the scope of v1.4.


## :question: Issue severity Team chose [`severity.Low`] Originally [`severity.Medium`] - [x] I disagree **Reason for disagreement:** I do not agree that simply using name and phone number is good enough to identify duplicates. As shown in the screenshot in my bug, the two applicants have same phone number, address and email but have different names. Just because of difference in name, they are treated differently, this error could occur if the user input the details of an application but misspelt the name. I believe a simple fix would be to use NRIC as a unique identifier instead which is within the scope of v1.4.