kyueran / pe

0 stars 0 forks source link

Overzealous phone number handling #9

Open kyueran opened 1 year ago

kyueran commented 1 year ago

It is mentioned in the UG to take the last input, so I assigned low severity to this case of overzealous phone number handling.

Steps to reproduce: add n/Tester p/+6587438807 p/99999999 e/alexyeoh@example.com a/Blk 30 Geylang Street 29, #06-40

Expected: Add person with 2 phone numbers

Actual: Only added the last phone number

For more detail, please refer to the screenshot below:

Screenshot 2023-04-14 at 2.39.22 PM.png

According to CS2103T website: Overzealous vali.png

soc-pe-bot commented 1 year ago

Team's Response

We specified that for the phone placeholder, if multiple numbers are provided, only the last number will be accepted.

But this is something that we can explore in the future to allow an applicant to have multiple numbers.

Screenshot 2023-04-16 at 10.38.23 AM.png

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: As shown in the screenshot I have attached from the CS2103T website, the problem of overzealous input validation is within the scope. This is a problem inherited from AB3 and is a valid bug.

Overzealous vali.png