Closed adrien-syrotnik closed 2 years ago
Hi Adrien,
I've been wanting to do this for a long time but getting to commit to it was hard part.
Since you have it working, do you mind raising a PR? You will find details in CONTRIBUTING.md
Please include a tests case in the spec file for this.
Hi,
I would like to create the PR but I don't really know how to create the spec file π . Do you have an example to help me do it ? I saw the DEVELOPER.md guide to run test, but i don't see how to test the new directive in this repo.
Sincerly.
Hi,
You could try adding new test case to ngPipe component in demo app. The actual directive doesn't have working unit tests yet.
And yes - it's DEVELOPER.md π
Closing this as we've merged the related PR #1642
:rocket: Feature request
Problem : couldn't pass args to the ngPipeInstance
I wanted to create new pipes with custom args in
transform()
method, but ngPipeInstance doesn't do it.I think a
ngPipeArgs
attribute can be a good idea (any[]
type).I tried this, but I'm surprised you didn't do it before, is there a reason ?
Thank you for your answer, Adrien.