search

l1f7 / surface

:construction: Building blocks & guidelines for front-end at Lift (deprecated: unmaintained)
2 stars 1 forks source link

update uikit package, update how theme folder is structured #22

Closed hyshka closed 7 years ago

hyshka commented 7 years ago

Please review and see issue #21 for previous discussion. Let me know if you have any further ideas, otherwise give the 'okay' so I can merge it into master.

stormwarning commented 7 years ago

Do we actually need the uikit mixins-theme & variables-theme.scss files if we're going to be overriding them? Wouldn't it make more sense to start from the UIKit baseline and build up?

If there's some common things we're doing we could always include those in our variables and mixins files here in Surface.

hyshka commented 7 years ago

I'm not sure about including the mixins-theme, variables-theme, and uikit-theme files over just the uikit base files but I think it's worth considering.

Also of note is that if we override any mixins we will lose the styles added in the mixins-theme file here: https://github.com/uikit/uikit/blob/v3.0.0-beta.27/src/scss/mixins-theme.scss

Therefore, if we were to override the hook-accordion-title mixin, for example, and wanted to retain some of the uikit-theme styles we'd have to copy the properties from the github source that we want and paste them into our own mixin.

I don't know how often we'd run into that but they don't actually have a tonne of mixins defined in the uikit-theme other than for inverse component styles (which in turn, override those inverse mixins from the base uikit mixins file).