l2- / template-plugin

BSD 2-Clause "Simplified" License
7 stars 8 forks source link

Plugin hub pages shows incorrect info for vanilla xp drops #93

Open Morcleon opened 6 months ago

Morcleon commented 6 months ago

Listed values on the wiki(?) page is as follows: Vanilla XP drop Size smallest: Font style: Default, Background: Shadow, Font size: 12, Icon size override: 0. Vanilla XP drop Size medium: Font style: Default, Background: Shadow, Font size: 16, Icon size override: 25. Vanilla XP drop Size largest: Font style: Bold, Background: Shadow, Font size: 16, Icon size override: 25. Vanilla XP drop Speed default: Vertical XP drop speed: 60. Vanilla XP drop Speed slower: Vertical XP drop speed: 44. Vanilla XP drop Speed faster: Vertical XP drop speed: 80.

While the values for Font Settings are correct, further testing has shown that the following XP Drop Settings for are required for precisely imitating vanilla xp drops: Size Largest/Medium + Speed Slower: XP drop delay: 13, Vertical XP drop speed: 96, Time until disappear: 139 Size Largest/Medium + Speed Default: XP drop delay: 9, Vertical XP drop speed: 144, Time until disappear: 93 Size Largest/Medium + Speed Faster: XP drop delay: 7, Vertical XP drop speed: 192, Time until disappear: 70 Size Smallest + Speed Slower: XP drop delay: 10, Vertical XP drop speed: 97, Time until disappear: 142 Size Smallest + Speed Default: XP drop delay: 6, Vertical XP drop speed: 144, Time until disappear: 96 Size Smallest + Speed Faster: XP drop delay: 5, Vertical XP drop speed: 194, Time until disappear: 71

l2- commented 6 months ago

Unfortunately it seems to depend on client size and I didn't realize at the time of writing those defaults. For example I found for size largest + speed faster that delay:6 speed:230 and time:71 matched vanilla but only when my client is maximized (1080p resolution). When i play on smaller client size the settings are completely off again. Very easy to test by turning off the somewhat recently added setting 'Hide vanilla xp drops' under miscellaneous in customizable xp drops plugin settings for those unaware. I'll update the readme. Thanks for bringing this up as I hadn't realized this yet.

Morcleon commented 6 months ago

Oh, interesting. I didn't think to test based on window size, so each implementation will probably have to be personalized for whatever size someone is using, rather than being able to use a single setup. My testing was done with Game Size settings of 1400x900.