Closed djhworld closed 6 years ago
I am experiencing the same.
Is it so difficult for slack to implement a dark theme? It is a electron (like web) site, so a CSS can make it.
@jlanza this project is CSS.... 4000 lines of it https://github.com/laCour/slack-night-mode/blob/master/css/black.css That's how Stylish themes work
I know, but at the end it is not official. This is what I meant. They should provide something official.
FYI it looks like #157 fixes this issue!
using https://raw.githubusercontent.com/tectiv3/slack-night-mode/master/css/raw/black.css as the CSS url to test it
I can confirm sandfox's comment above is a fix for both 2.8.2 and 3.1 Slack desktop clients for Linux. The latter, dark mode in 3.1, had been broken for months, while 2.8.2 just broke this morning. Both work now with that updated css URL. Woot!
I've merged in #159 which resolves this, and have cut a new release. Let me know if you still encounter issues.
This isn't fixed. @sandfox's link works from @tectiv3. This is in the desktop app adding the CSS to ssb-interop.js
$.ajax({
// Broken (white bg)
//url: 'https://cdn.rawgit.com/laCour/slack-night-mode/master/css/raw/black.css',
// Working
url: 'https://cdn.rawgit.com/tectiv3/slack-night-mode/master/css/raw/black.css',
success: function(css) {
$("<style></style>").appendTo('head').html(css);
}
});
});
@cbenard Do not use rawgit. Try https://raw.githubusercontent.com/laCour/slack-night-mode/master/css/raw/black.css instead.
That worked, but the rawgit one is in a prominent example that I presume far more than just me are using (see @sandfox's comment also using rawgit).
What are the differences between the hosts? Caching?
You may want to maintain a canonical set of code to inject in ssb-interop.js
rather than linking to that old issue comment (if you care about the desktop app).
Thanks for the fix!
Edit: I did some reading. githubusercontent.com
is owned by GitHub and serves everything as text/plain. RawGit is a caching proxy not run by GitHub at all but by a third party and serves the appropriate mimetypes. In the case of this CSS, I guess text/plain
doesn't matter. Good to know.
Slack must have made a change overnight, the background colour of the chat window has changed to white.