search

lab-cosmo / chemiscope

An interactive structure/property explorer for materials and molecules
http://chemiscope.org
BSD 3-Clause "New" or "Revised" License
121 stars 29 forks source link

Wrong text color with jupytelab 4 in darkmode #284

Open PicoCentauri opened 1 year ago

PicoCentauri commented 1 year ago

With JupyterLab in the dark theme the text of the pop up panels is white even though the background color is white as well (see screenshot below). When using the light theme the text is correctly displayed in black.

I suggest that the background color of the pop ups should be changed to black when jupyter is used with the dark theme.

Screenshot 2023-05-16 at 11 22 25
Luthaf commented 1 year ago

So what I think is happening here is that we are inheriting the text color from the root HTML, and jupyter changes that to white in dark mode.

The simplest fix would be to make sure we explicitly set text color to black/dark grey instead of inheriting the default.