search

labelle-org / labelle

Label printing software
Apache License 2.0
49 stars 8 forks source link

Fix Frequent overflow issues #68 on LabelManager 280 #76

Closed poita66 closed 1 month ago

poita66 commented 1 month ago

The overflow happens because the LabelManager 280 sends more than 8 bytes and the buffer is too small. This needs testing on other devices, but I expect that it'll be fine for them too.

LibUSB has no way of knowing how much data the device is going to send so if the supplied buffer size is too small, the overflow happens.

See https://libusb.sourceforge.io/api-1.0/libusb_packetoverflow.html for more info

maresb commented 1 month ago

Amazing, thanks @poita66! A brief test shows that this seems to work on the LabelManager PnP.

I don't know anything about USB buffer sizes. What is the tradeoff for increasing this to 16? In particular, why stop at 16? Would anything go wrong if we increased to 512? (512 seems to work for me as well.)

@jgoerzen, does this help for your situation?

@tomek-szczesny, @tomers, any other devices we could test this with?

poita66 commented 1 month ago

@maresb You make a great point. I'll test and update the PR. I only doubled it as my other projects are embedded and I was in the RAM-conservative mindset.

tomek-szczesny commented 1 month ago

Seems to be working fine on PnP. :)

maresb commented 1 month ago

I like this. I'm going to assume this is good until someone complains. Let's cut a release.