search

labexp / osmtracker-android

GPS tracking tool for OpenStreetMap
GNU General Public License v3.0
503 stars 237 forks source link

Export to public directory (Fix #443, Fix #440) #451

Closed Zahnstocher closed 4 days ago

Andyporras commented 1 week ago

Hi @Zahnstocher,

I’ve reviewed the PR "Export to public directory (Fix #443, Fix #440)," and I can confirm it works perfectly in both the current version and with the updates in PR #457 (target SDK 35). Excellent work!

However, I noticed a couple of points that could be improved:

The pull request currently lacks a description. Including a brief overview of the changes and their impact would make the PR more informative for reviewers.

The exported files are being saved in the Documents directory, which isn’t reflected in the current UI message. The message still mentions “External storage (SD) directory,” which might confuse users. Updating this text to accurately reflect the export location would improve clarity and usability.

Andyporras commented 1 week ago

Hi @Zahnstocher,

I’ve reviewed the PR "Export to public directory (Fix #443, Fix #440)," and I can confirm it works perfectly in both the current version and with the updates in PR #457 (target SDK 35). Excellent work!

However, I noticed a couple of points that could be improved:

The pull request currently lacks a description. Including a brief overview of the changes and their impact would make the PR more informative for reviewers.

The exported files are being saved in the Documents directory, which isn’t reflected in the current UI message. The message still mentions “External storage (SD) directory,” which might confuse users. Updating this text to accurately reflect the export location would improve clarity and usability.

To improve clarity for users, you could update this message in the file app/src/main/res/values/strings-preferences.xml, specifically on line 76, to reflect the correct export location. If you’d like, I can take care of making this change for you—just let me know!

Binnette commented 4 days ago

Hi @Andyporras, about the string in file "strings-preferences.xml" line 76. I would set this string simply to "Public directory". Tell me if you're good with this or propose me something else 👍

Andyporras commented 3 days ago

Hi @Andyporras, about the string in file "strings-preferences.xml" line 76. I would set this string simply to "Public directory". Tell me if you're good with this or propose me something else 👍

Thank you for the suggestion! I think "Public directory (in documents)" would be a bit more descriptive and helpful for users, as it clarifies where the files will be stored. Let me know if that works for you or if you'd prefer keeping it simpler.

This to make that change in pr #458.