labscript-suite-temp / labscript_devices

Module containing labscript suite hardware compatibility, separate from the main programs. Device compatibility is implemented with a plugin architecture, for modularity and extensibility. Each file in this module contains a labscript device class, a BLACS tab class, a BLACS worker class and a runviewer parser class for a particular device. These implement functionality for the device which the programs in question call on when they encounter each device in user labscript code, hdf5 files, or connection tables.
0 stars 0 forks source link

NI PCI 6733 labscruipt class incorrectly checks number of child devices #11

Closed philipstarkey closed 8 years ago

philipstarkey commented 9 years ago

Original report (archived issue) by Philip Starkey (Bitbucket: pstarkey, GitHub: pstarkey).


The NI PCI 6733 requires an even number of Analog outputs during a buffered shot. However, the labscript code just checks there are an even number of child devices. Since this card also supports digital outputs, you run into the following problems:

philipstarkey commented 8 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: pstarkey).


Fixed in changeset: 8334eeb09fa9a8dc28b496670be286735b21a599 and released as v2.0.1

philipstarkey commented 8 years ago

Original comment by Philip Starkey (Bitbucket: pstarkey, GitHub: pstarkey).