search

ladislav-zezula / StormLib

Official GitHub repository of the StormLib library created by Ladislav Zezula (author)
http://www.zezula.net/mpq.html
MIT License
563 stars 214 forks source link

MPQ Editor creates invalid archive entries using LZMA compression #283

Closed MadProbe closed 1 year ago

MadProbe commented 1 year ago

Steps to reproduce:

  1. Download MPQ Editor
  2. Go to settings, create custom ruleset with LZMA compression and nothing else
  3. Create an archive
  4. Copy some files into it
  5. Check added files (Verify files)

Additional info:

  1. files compressed with ZLIB are ok
  2. SC2 Editor cannot open archives with LZMA compression
  3. OS: Windows 10 21H1
  4. Archive is larger than normal one
  5. Using StormLib directly also fails and creates a corrupted archive
  6. Including MD5 and CRC32 with the archive has no effect

Screenshots: Failed Archive: image Ruleset: image Failed archive failed-archive.zip

ladislav-zezula commented 1 year ago

Fix: https://github.com/ladislav-zezula/StormLib/pull/285

Could you please download the latest MPQ editor and retry your use case? Link: http://zezula.net/download/mpqeditor_en_madprobe.zip

MadProbe commented 1 year ago

Fix: #285

Could you please download the latest MPQ editor and retry your use case? Link: http://zezula.net/download/mpqeditor_en_madprobe.zip

I've checked and I can confirm that fix is working properly