ladybug-tools / honeybee-energy

🐝 :fire: Honeybee extension for energy simulation
https://www.ladybug.tools/honeybee-energy/docs/
GNU Affero General Public License v3.0
28 stars 18 forks source link

Add Window Material .properties Extension Classes #1038

Closed ed-p-may closed 2 months ago

ed-p-may commented 2 months ago

Hi @chriswmackey

I wonder if you would be open to adding a few more .properties to properties.extension.py so that we can extend a few more classes? Specifically, we would like to add a .properties class for:

@ed-p-may / @PH-Tools

chriswmackey commented 2 months ago

Thanks, @ed-p-may . I don't have any objections and I think it's a good idea. Feel free to put together a PR and I'll review/merge.

ed-p-may commented 2 months ago

Ok great, I just sent though PR#1039. Let me know if you think you'd like any changes though. Thanks!

mostaphaRoudsari commented 2 months ago

@ed-p-may, should we close this issue now that the PR is merged?

ed-p-may commented 2 months ago

Yes: this is resolved now. Thanks!