search

ladybug-tools / honeybee-radiance-command

🐝 ⚡️ :abc: Honeybee wrapper around Radiance commands which is used by honeybee-radiance
https://www.ladybug.tools/honeybee-radiance-command/docs/
GNU Affero General Public License v3.0
0 stars 6 forks source link

Human visual response option in Pcond set incorrectly. #213

Closed ghost closed 2 years ago

ghost commented 2 years ago

https://github.com/ladybug-tools/honeybee-radiance-command/blob/master/honeybee_radiance_command/options/pcond.py#L73-L85

Almost certain that this is a bug, as there is no way that self.h.value will mean anything. Should be self._h.value instead. I am not sure if this option in Pcond is being used anywhere for the time being. Just making a note here to fix it later. Not a priority for now.

mostaphaRoudsari commented 2 years ago

Hi @built-tools! I would push a quick fix for this one.

@chriswmackey, should know if we are using this option.

mostaphaRoudsari commented 2 years ago

I just did push a fix so it shouldn't be an issue anymore: https://github.com/ladybug-tools/honeybee-radiance-command/pull/214

github-actions[bot] commented 2 years ago

:tada: This issue has been resolved in version 1.17.1 :tada:

The release is available on:

Your semantic-release bot :package::rocket: