ladybug-tools / uwg

:city_sunrise: The Urban Weather Generator (uwg) is a Python application for modeling the urban heat island effect.
https://www.ladybug.tools/uwg/docs/
GNU General Public License v3.0
56 stars 26 forks source link

Ventilation and infiltration definitions in building.py #253

Open gianlucamaracchini opened 3 years ago

gianlucamaracchini commented 3 years ago

Hi, looking at building.py, I found these args definitions in Building(): infil: Infiltration rate (ACH). vent: Ventilation rate (ACH). However, in Building() properties:

Looking at the code in building.py, it would seems that this second definition is the correct one, indeed:

total vent volumetric flow [m3 s-1]

    volVent = self.vent * self.nFloor
    volInfil = self.infil * UCM.bldHeight / \
        3600.  # Change of units AC/H -> [m3 s-1]

However, why using a different formulation for "infil" and "vent"?

Many thanks, G.

saeranv commented 3 years ago

@jmrk87

Yes that's a typo, the vent metric should be [m3 s-1 m-2]. Also the subsequent volVent and volInfil metric should actually be [m3 s-1 m-2] as well, since the building energy balance (and I think canyon as well) is normalized by floor area, or else those volumetric derivations don't make sense.

The different metrics are just due to different conventions used by the original DOE reference buildings.