search

ladybug-tools / uwg

:city_sunrise: The Urban Weather Generator (uwg) is a Python application for modeling the urban heat island effect.
https://www.ladybug.tools/uwg/docs/
GNU General Public License v3.0
56 stars 26 forks source link

Example UWG file in resources is out of date #255

Closed danieldjewell closed 3 years ago

danieldjewell commented 3 years ago

Issue is still unresolved from #139

The 6ff8e44ef0a35217d9f9bfc213c4dcbb926fdeff commit looks like it changed the format for the UWG file, specifically for how the bld parameter is read.

Trouble is, the example file in resources/ was never updated and it's still using the old format.

saeranv commented 3 years ago

@danieldjewell

You're going to have to clarify this a bit more. For one thing, issue #139 never indicated any errors with UWG, it was purely a user error, and so all the changes I made were mainly cosmetic (changing error messages, the README etc).

It'll be better to just share the code you're trying to run and what error message you're getting.

danieldjewell commented 3 years ago

Try running: https://github.com/ladybug-tools/uwg/blob/6ddbdc88a64034f748e98c0f157e434323399c7e/resources/initialize_singapore.uwg

It will fail because the format for bld is old... https://github.com/ladybug-tools/uwg/blob/6ddbdc88a64034f748e98c0f157e434323399c7e/resources/initialize_singapore.uwg#L58-L68

saeranv commented 3 years ago

@danieldjewell

Good catch! I did miss updating this file. Fixing it now.

saeranv commented 3 years ago

The updated file has be merged, thanks again @danieldjewell.

danieldjewell commented 3 years ago

The updated file has be merged, thanks again @danieldjewell.

No worries! Thank you! (Side note/suggestion -- maybe add some notes in the readme to look at some of the test files - they're more than just tests, they're also examples :) )