search

laforest / FPGADesignElements

A self-contained online book containing a library of FPGA design modules and related coding/design guides.
MIT License
387 stars 40 forks source link

fix typo #14

Closed pwang7 closed 2 years ago

laforest commented 2 years ago

Thank you for spotting the documentation typo.

However, I don't agree with renaming the Register inside the Register_Toggle module. Sometimes there is no further information to carry with a module instance name, and here the Register_Toggle module itself denotes what the Register is for.

Could you please undo that last change, and I can accept the pull request.

pwang7 commented 2 years ago

Thank you for spotting the documentation typo.

However, I don't agree with renaming the Register inside the Register_Toggle module. Sometimes there is no further information to carry with a module instance name, and here the Register_Toggle module itself denotes what the Register is for.

Could you please undo that last change, and I can accept the pull request.

Done.

Just spot more typo, ADDR_WIDTH**2 -> 2**ADDR_WIDTH.

laforest commented 2 years ago

Thank you!

pwang7 commented 2 years ago

BTW, will you continue writing this book? Your book is very helpful~

laforest commented 2 years ago

Oh yes. I've been busy with other parts of the book for a while. I have an update going out soon. I'm glad you are finding it helpful. Thank you!