Modify the style and height of the tabs dialog

[mauriciobellon]

Hi @bbeaulant,

Firstly, 7.0 is looking cool. :)

I found these to small improvements that could be done in plugin.rb.

1. Changing the style of the tabs dialog from UI::HtmlDialog::STYLE_DIALOG to UI::HtmlDialog::STYLE_UTILITY, which will result in the dialog having a more utility-like appearance.

2. Increasing the minimum height of the tabs dialog from 30 + 80 + 80 * 3 to 30 + 80 + 80 * 4, which will make room for the new Structure tab button.

Correct me if there is a reason to use STYLE_DIALOG on the creation of the dialog instance, as I couldn't find any in the Sketchup API Reference. I don't know the impact that would make on macOS, but in windows to me, it makes sense.

STYLE_DIALOG

STYLE_UTILITY

One last thing, can I contribute to the dev of the project, I'm truly interested? If the answer is yes, how do you assign issues?

Regards

[bbeaulant]

Hello @mauriciobellon,

Thank you for your proposal. Yes, on Windows the minimized dialog is awful because of the size of the windows buttons. Even if utility dialog seems to be a solution, it's not really, because it can't be resized manually. And that's a big negative point.

As I can see on youtube, a lot of user uses the Windows maximize button to switch OCL to fullscreen. Switching to utility will remove this capability too.

I don't know the impact that would make on macOS

No problem with DIALOG on MacOS 😉

One last thing, can I contribute to the dev of the project, I'm truly interested?

To be honest, currently, I don't know. Core part of the code is done by myself, I like the freedom it represents and that's why I love working on this project. And I think that I must work differently if one more person work on the same portion of code. What would you have liked to do on this project?

[bbeaulant]

Increasing the minimum height of the tabs dialog from 30 + 80 + 80 3 to 30 + 80 + 80 4, which will make room for the new Structure tab button.

I think that displaying "Import" button is not necessary. This is not really a key feature. On small screens a minimized window with 4 buttons mays hide too large a portion of the screen. That's why I keep only 3 vivible.

[mauriciobellon]

In fact, it is difficult to change the looks at this point.

Just some considerations on your comments.

Even if utility dialog seems to be a solution, it's not really, because it can't be resized manually. And that's a big negative point.

Resizing using STYLE_UTILITY works on Windows

As I can see on youtube, a lot of user uses the Windows maximize button to switch OCL to fullscreen. Switching to utility will remove this capability too.

Double click on the dialogs title bar raises it to fullscreen and brings it back on Windows

On small screens a minimized window with 4 buttons mays hide too large a portion of the screen. That's why I keep only 3 vivible.

Makes sense, on Windows though the height of the dialog seems to be off, showing part of the fourth button, as my first img in the first comment, maybe could be solved by putting Import on the bottom of the opened nav with Doc..

No problem with DIALOG on MacOS 😉

Loved the looks on macOS :)

To be honest, currently, I don't know. Core part of the code is done by myself, I like the freedom it represents and that's why I love working on this project. And I think that I must work differently if one more person work on the same portion of code. What would you have liked to do on this project?

I see that it can change things, will reflect on that and get back to you.

[bbeaulant]

Resizing using STYLE_UTILITY works on Windows

Hmm, as far as I remember something went wrong when I try on my Windows 10 🤔

Double click on the dialogs title bar raises it to fullscreen and brings it back on Windows

Yes, but only geek users know this trick...

Loved the looks on macOS :)

Of course, what kind of designer can align a button like this ... 🙄 ?

on Windows though the height of the dialog seems to be off

I know, but Windows compatibility is a nightmare. Maybe it different on SU 23-. Trimble may fix something in SU24. Before the title bar was count in dialog height ...