search

lake-lerna / hydra

A Scale Testing infra using Mesos and marathon
Apache License 2.0
13 stars 8 forks source link

Add/Delete tasks from group #80

Closed tahir24434 closed 8 years ago

tahir24434 commented 8 years ago

Earlier, addition/deletion of tasks to/from tasks group was not possible. For subscriber list length check, we need this flexibility. Using this commit, you can make changes to existing group by adding/deleting tasks from the group.

sushilks commented 8 years ago

Looks fine to me, @kratos7 Please merge when you are done with your review.

kratos7 commented 8 years ago

@tahir24434 Do you plan to push a patch with comments addressed ? Also please make sure to run the full end to end kraken test suite with these changes since all tests extensively use the group api. Once you put your OK here I will merge.

sushilks commented 8 years ago

@tahir24434 @kratos7 as a policy It's best to not merge your own commit.

tahir24434 commented 8 years ago

Makes sense. Actually, there were two commits, one on corelib and another on hydra side. Both of the commits needed to go together. Shijeesh had rights only to corelib side (in my opinion). Since both Abdullah and you gave comments that hydra commit is fine, I thought that there was no issue. However, I agree that policy should be followed. I will be careful.

On Fri, Aug 26, 2016 at 5:23 PM, Sushil Singh notifications@github.com wrote:

@tahir24434 https://github.com/tahir24434 @kratos7 https://github.com/kratos7 as a policy It's best to not merge your own commit.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/lake-lerna/hydra/pull/80#issuecomment-242882701, or mute the thread https://github.com/notifications/unsubscribe-auth/ADodk8JXPQRmiU09wMzAjP0lEs89BzfIks5qj4NogaJpZM4JrhdU .

Tahir Rauf (408) 797-5986