search

lambdaclass / ethrex

ethrex: Ethereum Rust Execution L1 and L2 client.
Apache License 2.0
261 stars 25 forks source link

Check the discovery service #448

Open fkrause98 opened 2 months ago

fkrause98 commented 2 months ago

Fix/Check

While implementing #436, I stumbled upon the fact that this line seems to block the loop, if this is the case, we should use a select! statement as to not block the scheduler.

MarcosNicolau commented 2 months ago

This is an asynchronous operation, so, as far as I know, it isn't blocking the scheduler. It would be blocking if the socket is from std instead of tokio.