search

lambdalisue / vim-gista

An alternative gist.vim, vim plugin which manipulate gists in Vim.
http://www.vim.org/scripts/script.php?script_id=4976
MIT License
156 stars 5 forks source link

Import default username from 'git config github.user' #64

Closed tyru closed 8 years ago

tyru commented 8 years ago

Import default GitHub username from git config github.user if it is present. This PR can get rid of duplicate configuration in .vimrc and .gitconfig .

tyru commented 8 years ago

FYI, themis command fails on my local machine... I don't know this is a problem, just to tell you.

$ themis
Bail out!  Error occurred in script loading.
# function vital#of(name) abort  Line:4  (~/.vim/bundle/vim-themis/autoload/vital.vim)
#   4:     throw 'vital: version file not found: ' . a:name
# vital: version file not found: vital
lambdalisue commented 8 years ago

FYI, themis command fails on my local machine... I don't know this is a problem, just to tell you.

You need to create ~/.themisrc like

call themis#option('runtimepath', expand('~/.vim/bundle/vimproc.vim'))
call themis#option('runtimepath', expand('~/.vim/bundle/vital.vim'))

Or apply --runtimepath options to themis command ;-)

lambdalisue commented 8 years ago

Thanks for implementation. I pointed two things so please fix these ;-)

tyru commented 8 years ago

Okay. I will fix those for later.

lambdalisue commented 8 years ago

I changed my mind. The default value of the option should be 1 while majority of people prefer to login I guess.

tyru commented 8 years ago

Okay :)

tyru commented 8 years ago

Fixed. Please confirm it.

lambdalisue commented 8 years ago

LGTM. Could you add document?

tyru commented 8 years ago

Added.

lambdalisue commented 8 years ago

Thanks a lot ;~) I'll add other documents later.

tyru commented 8 years ago

My pleasure!