lamda-bbo / offline-moo

Official implementation of ICML'24 paper "Offline Multi-Objective Optimization".
15 stars 4 forks source link

Import Errors in scripts/multi_head_nn.py and scripts/multi_obj_nn.py #3

Closed yassineCh closed 2 months ago

yassineCh commented 3 months ago

The scripts scripts/multi_head_nn.py and scripts/multi_obj_nn.py are importing mo_solver from the algorithm folder. I had to change it to import from off_moo_baselines to run the scripts. Additionally, the hv function is missing the task_name argument:

hv_value = hv(nadir_point, res_y) TypeError: hv() missing 1 required positional argument: 'task_name'

Please update the import paths or clarify the correct structure.

Thank you for your support.

trxcc commented 3 months ago

Hi @yassineCh

Thanks for your issue!

After checking our source code, I found some bugs in scripts/multi_head_nn.py and scripts/multi_head_nn.py, which may have been caused by errors during our maintenance of the newer version of the code (under the off_moo_baselines directory). The bugs have now been fixed.

If you have any questions, feel free to contact us.

yassineCh commented 3 months ago

Thank you for the quick fix. You still need to update scripts/multi_obj_nn.py and scripts/run_mobo_once.py to add task_name when calling hv().

trxcc commented 2 months ago

Thank you for your suggestion. We have updated scripts/multi_obj_nn.py and script/run_mobo_once.py.