Psalm integration - Githubissues

laminas / laminas-json-server

Laminas Json-Server is a JSON-RPC server implementation.

https://docs.laminas.dev/laminas-json-server/

BSD 3-Clause "New" or "Revised" License

17 stars 6 forks source link

Psalm integration #15

Closed ghostwriter closed 2 years ago

ghostwriter commented 3 years ago

Q	A
QA	yes

Description

[x] Create psalm.xml.dist
[x] Require vimeo/psalm
[x] Create psalm-baseline.xml
[x] Require psalm/plugin-phpunit
[x] Upgrade phpunit/phpunit ^9.5
[x] Add static-analysis composer script
[x] Normalize composer.json
[x] Update composer.lock

Fixes #10

froschdesign commented 3 years ago

@ghostwriter

Normalize composer.json

Can you tell me on what basis this was done? Thanks!

ghostwriter commented 3 years ago

@froschdesign (QA) To help us keep our composer.json nice and tidy, so we do not have to worry about it's structure and or formatting.

restructure composer.json according to the underlying JSON schema.
sort entries in the bin section (by value)
sort entries in the config, extra, and scripts-descriptions sections (by key)
sort entries in the conflict, provide, replace, require, require-dev, and suggest sections (as you are used to from the sort-packages configuration)
normalize version constraints in conflict, provide, replace, require, and require-dev sections

froschdesign commented 3 years ago

@ghostwriter I know the idea behind the normalization and also the Composer plugin but I don't know that we use this everywhere. So I assume it's a suggestion from you.

ghostwriter commented 3 years ago

@froschdesign Yes, that is correct. (hopefully a RFC wasn’t required)

Used in most, if not all, PRs that I submit, that touch composer.json file
Would like to see it added to the QA Checks

froschdesign commented 3 years ago

@ghostwriter

hopefully a RFC wasn’t required

The problem is that inconsistencies arise between the repositories which can be result in more work or other problems. And with more than 180 repositories in 3 different GitHub organizations, nobody needs that.

Would like to see it added to the QA Checks

Please open an issue report at https://github.com/laminas/laminas-continuous-integration-action Thanks in advance! 👍

ghostwriter commented 3 years ago

@froschdesign That is not a problem at all.

I will take care of the PRs for all 3 orgs and send a PR to laminas/laminas-continuous-integration-action adding ergebnis/composer-normalize to the QA/CI process.

It can, and will, be consistent going forward.

ghostwriter commented 3 years ago

@froschdesign Reverted the last 2 commits in favor of #17