Fix json server error return type to always be `int` - Githubissues

laminas / laminas-json-server

Laminas Json-Server is a JSON-RPC server implementation.

https://docs.laminas.dev/laminas-json-server/

BSD 3-Clause "New" or "Revised" License

17 stars 6 forks source link

Fix json server error return type to always be `int` #33

Closed alexmerlin closed 1 year ago

alexmerlin commented 1 year ago

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	no
RFC	no
QA	yes

Description

Fixed an error thrown during Psalm analysis.

Error: src/Error.php:67:13: DocblockTypeContradiction: Cannot resolve types for $code - docblock-defined type int does not contain float (see https://psalm.dev/155

Also:

added missing return type declarations for the function's in src/Error.php
added missing /.phpcs-cache to .gitignore so it does not get committed to the repo