QA: strict types

[arueckauer]

Q	A
Documentation	no
Bugfix	no
BC Break	no
New Feature	no
RFC	no
QA	yes

Description

This PR provides strict typing as described in #2 .

• Add strict type declaration
• Add return type declaration
• Add argument type declaration (where applicable)
• Fix type errors
• Remove tests which are made redundant by type declaration
• Fix second parameter type in calls of var_export

[arueckauer]

👋🏻 and thanks for the review. That's great input! Most comments are fine, for a few I had a question.

Since this PR is about adding strict typing to the component. I would like to address changes not related to it separately. Would you be okay with me opening issues for the following list? They would be addressed in dev-4.0 (master respectively for bugfixes).

• Drop fluent setters
• Avoid yoda conditions
• Drop Json::encode & Json::decode in favor of native json_encode and json_decode (add ext-json to composer.json)
• Drop PHPDocs which do not add valuable information (such as duplicating type declarations)
• ExceptionInterface should extend Throwable
• Apply laminas/laminas-coding-standard 2.0
• Bugfix Smd::getDescription() returns $description instead of self
• Handle array arguments more generic, probably iterable (e.g. Smd::addServices(array $services))
• Smd::addService(Smd\Service $service) drop array support and argument type check [BC]
• JSON-RPC SMD: Use argument type declarations as param types (deprecating type hints in PHPDocs)

EDIT: Added JSON-RPC SMD: Use argument type declarations as param types (deprecating type hints in PHPDocs) to list of changes.

[michalbundyra]

@arueckauer Maybe add these as checkboxes to #2 (edit the description) and then provide separate PRs to dev-4.0. What do you think?

EDIT:

Bugfix Smd::getDescription() returns $description instead of self

PR to master please.

[arueckauer]

Agreed, I added the list.

There is one unresolved conversation about initial value of Smd\Service::$name. Would love your input on that.

[michalbundyra]

@arueckauer Also for strict types we should use assertSame instead of assertEquals (the same as === instead of ==).