search

lampepfl / gears

A strawman for a low-level async library in Scala 3.
https://lampepfl.github.io/gears/
Apache License 2.0
247 stars 24 forks source link

chore: Fix execute not start vt issue. #39

Closed He-Pin closed 7 months ago

He-Pin commented 7 months ago

Motivation: In my last pr, I forgot to start the VT :(

Result: Fixed :)

natsukagami commented 7 months ago

Can you add a test to make sure things work as expected? I could also add one if wanted.

He-Pin commented 7 months ago

Sorry, I still can't build the snapshot out locally, and a little busy at work. cherry pick if you like. Sorry for missed the start call in my last pr.

natsukagami commented 7 months ago

No worries, I'll add a test onto your branch.

Sorry, I still can't build the snapshot out locally,

Did you run into problems running dependencies/publish-deps.sh?

He-Pin commented 7 months ago

I'm using Windows 11, so I didn't

natsukagami commented 7 months ago

Sorry for the force-push, I wanted to rebase it to the latest upstream main branch

He-Pin commented 7 months ago

@natsukagami Thanks I want to learn how to force push to a contributor branch too

natsukagami commented 7 months ago

force push to a contributor branch

As long as "Maintainers are allowed to edit this pull request." I think regular git push -f works. You need to set the correct upstream for the branch, but if you have GitHub cli it's easy to have it automate all the setting up for you: gh pr checkout 39.

He-Pin commented 7 months ago

@natsukagami I can't install the github cli, company doesn't allow it. thank you ,just learn something new