search

lancejpollard / authlogic-connect

Instant Oauth and OpenID support for your Rails and Sinatra Apps
MIT License
148 stars 27 forks source link

symbolizing session keys make errors for flash #46

Open pftg opened 13 years ago

pftg commented 13 years ago

Hi we found that you symbolize keys of session, which make flash bad. in: lib/authlogic_connect/common/variables.rb:

23: def auth_session 24: return nil unless auth_controller? 25: auth_controller.session.symbolize_keys!

Also after reviewing this method, I do not see where you use symbols, you use strings for compare:

27: if key.to_s =~ /^OpenID/

My solution is to remove 25 line.

My rails version is 2.3.10, where FlashNow use session["flash"].

With regards, Paul

carlosantoniodasilva commented 13 years ago

This issue is also happening in our application, we cannot simply convert all session/params keys to symbols. By converting the session keys to symbols, the flash hash does not work anymore.

carlosantoniodasilva commented 13 years ago

I've just sent a pull request to fix the issue: https://github.com/viatropos/authlogic-connect/pull/47