search

landley / toybox

toybox
http://landley.net/toybox
BSD Zero Clause License
2.44k stars 340 forks source link

Use POSIX-compliant `od -A` argument value #518

Closed andrewliebenow closed 2 months ago

andrewliebenow commented 2 months ago

POSIX only specifies the characters 'd', 'o', 'x', and 'n' as valid od -A argument values. [1] Pedantic implementations of od may expect the argument value to be a single character instead of ignoring these extra characters. [2]

[1] https://pubs.opengroup.org/onlinepubs/9799919799/utilities/od.html [2] https://github.com/uutils/coreutils/pull/6674

landley commented 2 months ago

What od implementation did you use that broke?

andrewliebenow commented 2 months ago

@landley The implementation in the uutils coreutils project. I linked the PR I opened to make it less picky.

landley commented 2 months ago

I should do a FAQ entry for scripts/prereq/build.sh. Commit 3bbc31c78b41 explains it though. (Toybox can build its own prerequisites.)

andrewliebenow commented 2 months ago

Oh, that's cool. Thanks.