search

lando / pantheon

The Official Lando Pantheon plugin.
https://docs.lando.dev/pantheon
GNU General Public License v3.0
10 stars 14 forks source link

Specifying `framework: drupal10` leads to error #242

Closed karldivad closed 2 weeks ago

karldivad commented 3 weeks ago

When updating .lando.yml file to drupal10 it breaks nginx container with the following error:

sed: read error on /tmp/vhosts.conf.lando: Is a directory

Example lando file:

name: example-project
recipe: pantheon
config:
  framework: drupal10
  site: example-project
  id: 123456789-qwertyuiop
reynoldsalec commented 2 weeks ago

@karldivad I think the reason this hasn't been an issue is that when Lando assigns a framework value, it uses a value provided by Pantheon that uses a different value (say drupal8 for sites up to Drupal 10)...made a follow-up issue to make sure the recipe is really handling this well: #245

For the time being, definitely agree that to prevent user confusion allowing a drupal10 framework value is good and that your PR should resolve that issue...totally see how it's confusing. Thanks for the contribution @karldivad!