Hurricup/optimizations 1

[SteVio89]

Summary by CodeRabbit

• New Features

  • Enhanced language management with the introduction of singleton patterns for GermanyGerman and French classes, improving resource management and consistency.

• Bug Fixes

  • Updated instantiation methods to ensure proper use of singleton instances, preventing potential memory issues from multiple instantiations.

• Documentation

  • Improved clarity in test assertions and method calls, enhancing readability and maintainability.

• Chores

  • Reorganized import statements for better structure and consistency across various classes and tests.

[coderabbitai[bot]]

Walkthrough

This pull request introduces significant modifications across various classes in the LanguageTool project, primarily focusing on the instantiation of language classes using a singleton pattern. The changes affect how instances of GermanyGerman and French are created, replacing direct instantiation with calls to getInstance(). This approach aims to enhance resource management and consistency. Additionally, various methods and tests have been updated to reflect these changes, ensuring that the new instantiation logic is uniformly applied throughout the codebase.

Changes

File Path	Change Summary
languagetool-core/src/main/java/org/languagetool/Languages.java	Updated import statements; modified staticAndDynamicLanguages initialization; adjusted logic in getAllLanguages() to include "Premium" language classes; refined getLanguageForLocale() fallback logic.
languagetool-dev/src/main/java/org/languagetool/dev/GenderWordFinder.java	Changed instantiation of GermanyGerman to GermanyGerman.getInstance().
languagetool-dev/src/main/java/org/languagetool/dev/GermanOldSpellingFinder.java	Changed instantiation of GermanyGerman to GermanyGerman.getInstance() in both main and main2 methods.
languagetool-dev/src/main/java/org/languagetool/dev/MissingGermanCompoundAdjectiveFinder.java	Updated instantiation of Tagger and GermanSpellerRule to use GermanyGerman.getInstance().
languagetool-dev/src/main/java/org/languagetool/dev/MissingGermanCompoundsFinder.java	Changed instantiation of GermanSpellerRule to GermanyGerman.getInstance().
languagetool-dev/src/main/java/org/languagetool/dev/MissingGermanWords.java	Updated instantiation of GermanSpellerRule to GermanyGerman.getInstance().
languagetool-dev/src/main/java/org/languagetool/dev/archive/GermanTaggerEnhancer.java	Changed instantiation of Tagger to GermanyGerman.getInstance().getTagger().
languagetool-dev/src/main/java/org/languagetool/dev/archive/SimpleRuleCounter.java	Updated method call from new GermanyGerman() to GermanyGerman.getInstance().
languagetool-dev/src/main/java/org/languagetool/dev/bigdata/GermanReflexiveVerbGuesser.java	Changed instantiation of synthesizer to GermanyGerman.getInstance().
languagetool-dev/src/test/java/org/languagetool/dev/bigdata/CommonCrawlToNgramTest.java	Updated instantiation of CommonCrawlToNgram to GermanyGerman.getInstance().
languagetool-language-modules/de-DE-x-simple-language/src/main/java/org/languagetool/language/SimpleGerman.java	Changed instantiation of GermanRuleDisambiguator to getInstance().
languagetool-language-modules/de/src/main/java/org/languagetool/language/German.java	Updated method calls to use GermanyGerman.getInstance(); added new constant GERMAN_SHORT_CODE.
languagetool-language-modules/de/src/main/java/org/languagetool/language/GermanyGerman.java	Added getInstance() method; deprecated constructor.
languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/GermanCompoundRule.java	Updated references from Languages.getLanguageForShortCode("de-DE") to GermanyGerman.getInstance().
languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/GermanNumberInWordFilter.java	Changed instantiation to GermanyGerman.getInstance().
languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/GermanRepeatedWordsRule.java	Updated instantiation to GermanyGerman.getInstance().
languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/MissingCommaRelativeClauseRule.java	Changed instantiation method for ANTI_PATTERNS to GermanyGerman.getInstance().
languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/PotentialCompoundFilter.java	Updated instantiation to GermanyGerman.getInstance().
languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/ProhibitedCompoundRule.java	Changed instantiation to GermanyGerman.getInstance().
languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/RemoveUnknownCompoundsFilter.java	Updated instantiation to GermanyGerman.getInstance().
languagetool-language-modules/de/src/main/java/org/languagetool/rules/de/ValidWordFilter.java	Changed instantiation to GermanyGerman.getInstance().
languagetool-language-modules/de/src/test/java/org/languagetool/dev/bigdata/CommonCrawlToNgramTest.java	Updated instantiation of CommonCrawlToNgram to GermanyGerman.getInstance().
languagetool-language-modules/fr/src/main/java/org/languagetool/language/BelgianFrench.java	Added instantiationTrace field; updated constructor logic.
languagetool-language-modules/fr/src/main/java/org/languagetool/language/CanadianFrench.java	Added instantiationTrace field; updated constructor logic.
languagetool-language-modules/fr/src/main/java/org/languagetool/language/French.java	Added FRENCH_SHORT_CODE; deprecated default constructor; added getInstance() method.
languagetool-language-modules/fr/src/main/java/org/languagetool/language/SwissFrench.java	Added instantiationTrace field; updated constructor logic.
languagetool-language-modules/fr/src/main/java/org/languagetool/rules/fr/FindSuggestionsFilter.java	Updated instantiation of MorfologikFrenchSpellerRule to French.getInstance().
languagetool-language-modules/fr/src/main/java/org/languagetool/rules/fr/FrenchNumberInWordFilter.java	Changed instantiation to French.getInstance().
languagetool-language-modules/fr/src/main/java/org/languagetool/rules/fr/FrenchPartialPosTagFilter.java	Updated instantiation to French.getInstance().
languagetool-language-modules/fr/src/main/java/org/languagetool/rules/fr/FrenchRepeatedWordsRule.java	Changed instantiation to French.getInstance().
languagetool-language-modules/fr/src/main/java/org/languagetool/rules/fr/InterrogativeVerbFilter.java	Updated instantiation of morfologikRule to French.getInstance().
languagetool-language-modules/fr/src/main/java/org/languagetool/tagging/disambiguation/fr/FrenchHybridDisambiguator.java	Changed instantiation of disambiguator to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/FrenchConcurrencyTest.java	Updated instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/JLanguageToolTest.java	Changed instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/rules/fr/AnnotatedTextTest.java	Updated instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/rules/fr/GenericUnpairedBracketsRuleTest.java	Changed instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/rules/fr/MorfologikFrenchSpellerRuleTest.java	Updated instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/rules/fr/QuestionWhitespaceRuleTest.java	Changed instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/rules/fr/QuestionWhitespaceStrictRuleTest.java	Updated instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/rules/fr/SimpleReplaceRuleTest.java	Changed instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/rules/spelling/hunspell/TestFrenchDisambiguator.java	Updated instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/tagging/disambiguation/rules/fr/FrenchRuleDisambiguatorTest.java	Changed instantiation of French to French.getInstance().
languagetool-language-modules/fr/src/test/java/org/languagetool/tagging/fr/FrenchTaggerTest.java	Updated instantiation of French to French.getInstance().
languagetool-server/src/test/java/org/languagetool/server/HTTPSServerTest.java	Changed instantiation of GermanyGerman to GermanyGerman.getInstance().
languagetool-server/src/test/java/org/languagetool/server/HTTPServerTest.java	Updated instantiation of GermanyGerman to GermanyGerman.getInstance().
languagetool-standalone/src/test/java/org/languagetool/JLanguageToolTest.java	Changed instantiation of GermanyGerman to GermanyGerman.getInstance().
languagetool-standalone/src/test/java/org/languagetool/LanguageTest.java	Updated equality checks to use GermanyGerman.getInstance().
languagetool-standalone/src/test/java/org/languagetool/dev/MultiThreadingTest2.java	Changed instantiation of GermanyGerman to GermanyGerman.getInstance().
languagetool-standalone/src/test/java/org/languagetool/gui/ConfigurationTest.java	Updated instantiation of French to French.getInstance().
languagetool-standalone/src/test/java/org/languagetool/rules/patterns/StartupTimePerformanceTest.java	Updated instantiation of GermanyGerman to GermanyGerman.getInstance().
languagetool-wikipedia/src/test/java/org/languagetool/dev/index/IndexerSearcherTest.java	Changed instantiation of French to French.getInstance() and GermanyGerman to GermanyGerman.getInstance().
languagetool-wikipedia/src/test/java/org/languagetool/dev/wikipedia/SuggestionReplacerTest.java	Updated instantiation of GermanyGerman to GermanyGerman.getInstance().
languagetool-wikipedia/src/test/java/org/languagetool/dev/wikipedia/WikipediaQuickCheckTest.java	Changed instantiation of GermanyGerman to GermanyGerman.getInstance().

Possibly related PRs

• #10883: The changes in the main PR regarding the Languages class and the handling of language instances are related to the optimizations made in the getSentenceWithImmunization method of the Rule class, which also focuses on improving performance in language processing tasks. Both PRs aim to enhance the efficiency of language handling within the LanguageTool framework.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

🪧 Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[hurricup]

Here is the next one https://github.com/languagetool-org/languagetool/pull/11064