lanl / PyBNF

An application for parameterization of biological models available in SBML and BNGL formats. Features include parallelization, metaheuristic optimization algorithms, and an adaptive Markov chain Monte Carlo (MCMC) sampling algorithm.
Other
22 stars 18 forks source link

Floating stepsize not supported for time_course #314

Open StefanHauer opened 1 year ago

StefanHauer commented 1 year ago

When changing the demo example from integer timepoints (in the .exp file) to floating timepoints with a stepsize of 0.1 (in the .conf file) and changing nothing else, the following error will occur: "Sorry, an unknown error occurred: ValueError: invalid literal for int() with base 10: '0.1'"

This issue seems to be easily fixed by changing in the config.py file on line 377 int to float. However, I have tried runing the "run_all.py" test file, but the tests seem to fail both before and after my changes, due to me using Windows and the "run_all.py" script seems to be not Windows compatible. As a consequence I do not seem to be able to verify if this change breaks any other functionality.

wshlavacek commented 1 year ago

Hi Stefan, Thanks for alerting us to this issue. What version of PyBNF are you using? --Bill

On Sat, Dec 3, 2022 at 12:05 PM StefanHauer @.***> wrote:

When changing the demo example from integer timepoints (in the .exp file) to floating timepoints with a stepsize of 0.1 (in the .conf file) and changing nothing else, the following error will occur: "Sorry, an unknown error occurred: ValueError: invalid literal for int() with base 10: '0.1'"

This issue seems to be easily fixed by changing in the config.py file on line 377 int to float. However, I have tried runing the "run_all.py" test file, but the tests seem to fail both before and after my changes, due to me using Windows and the "run_all.py" script seems to be not Windows compatible. As a consequence I do not seem to be able to verify if this change breaks any other functionality.

— Reply to this email directly, view it on GitHub https://github.com/lanl/PyBNF/issues/314, or unsubscribe https://github.com/notifications/unsubscribe-auth/AETOR55ADXJN4F3RTVDXZHTWLOKYBANCNFSM6AAAAAASS4S4SM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

wshlavacek commented 1 year ago

Also... what version of NumPy are you using?

On Sat, Dec 3, 2022 at 12:05 PM StefanHauer @.***> wrote:

When changing the demo example from integer timepoints (in the .exp file) to floating timepoints with a stepsize of 0.1 (in the .conf file) and changing nothing else, the following error will occur: "Sorry, an unknown error occurred: ValueError: invalid literal for int() with base 10: '0.1'"

This issue seems to be easily fixed by changing in the config.py file on line 377 int to float. However, I have tried runing the "run_all.py" test file, but the tests seem to fail both before and after my changes, due to me using Windows and the "run_all.py" script seems to be not Windows compatible. As a consequence I do not seem to be able to verify if this change breaks any other functionality.

— Reply to this email directly, view it on GitHub https://github.com/lanl/PyBNF/issues/314, or unsubscribe https://github.com/notifications/unsubscribe-auth/AETOR55ADXJN4F3RTVDXZHTWLOKYBANCNFSM6AAAAAASS4S4SM . You are receiving this because you are subscribed to this thread.Message ID: @.***>

StefanHauer commented 1 year ago

Hi Bill, I am using version 1.23.1 of numpy and I downloaded the latest version directly here from Github so 1.2.0. Best regards, Steve

wshlavacek commented 1 year ago

Hi Steve, Your problem seems related to a problem that one of our students is having, who perhaps coincidentally is also working on a Windows machine. We're not quite sure what's going on, because we're having trouble reproducing the problem. The problem is related to the new version of NumPy, which you are using. Here's a workaround that should work. Use Anaconda to build a virtual environment with… Python version 3.9.7 (vs. 3.10) NumPy version 1.22.1 (vs. 1.23) Then pip install PyBNF If you have trouble creating the virtual environment, we can send you a Jupyter notebook Please let us know us know how things go - it would help us fix the problem --Bill

On Sun, Dec 4, 2022 at 8:24 AM StefanHauer @.***> wrote:

Hi Bill, I am using version 1.23.1 of numpy and I downloaded the latest version directly here from Github so 1.2.0. Best regards, Steve

— Reply to this email directly, view it on GitHub https://github.com/lanl/PyBNF/issues/314#issuecomment-1336439161, or unsubscribe https://github.com/notifications/unsubscribe-auth/AETOR53FRBSF4AYKSKYVY3DWLSZUNANCNFSM6AAAAAASS4S4SM . You are receiving this because you commented.Message ID: @.***>