search

lanl / nuflood

An open-source software project for surface water simulation.
Other
7 stars 6 forks source link

Documentation and examples #3

Open jbensabat opened 4 years ago

jbensabat commented 4 years ago

Hello is there any documentation and/or examples for nuflood ? thanks jac

tasseff commented 4 years ago

@jbensabat, at the moment, neither are included in this repository. I've wanted to incorporate good documentation and tests for quite a while but unfortunately do not have the time nor funding to do so. Knowing that others like yourself are interested, I may try improving this in my free time, but I cannot guarantee it will be done anytime soon.

jbensabat commented 4 years ago

Hello I have managed to compile and build the code under MSVC++. Would it be possible for your to send me a sample data set for overland flow so I could learn as I run. Any very simple example would make it, like a rainfall-runoff problem best regards jac

Jacob Bensabat, Ph.D. EWRE Ltd. 3, Shaar Halevanon Street Haifa – 3445402 Israel. Tel: +972-4-8383919 Mobile: +972-544417511 [EWRELogoNew]

From: Byron Tasseff notifications@github.com Sent: Wednesday, May 13, 2020 5:22 PM To: lanl/nuflood nuflood@noreply.github.com Cc: Jbensabat jbensabat@ewre.com; Mention mention@noreply.github.com Subject: Re: [lanl/nuflood] Documentation and examples (#3)

@jbensabathttps://github.com/jbensabat, at the moment, neither are included in this repository. I've wanted to incorporate good documentation and tests for quite a while but unfortunately do not have the time nor funding to do so. Knowing that others like yourself are interested, I may try improving this in my free time, but I cannot guarantee it will be done anytime soon.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/lanl/nuflood/issues/3#issuecomment-628022289, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZNJ2GYHX36TI6FUWAU6KTRRKUGXANCNFSM4M7XY7YQ.

tasseff commented 4 years ago

@jbensabat, sorry for the delay! I will try to add a rainfall-runoff example to this repository over the weekend.

jbensabat commented 4 years ago

Hi Thanks a lot. I am much more acquainted with the code now and I see that it solves the problem in a pixel-wise manner (from the elevation file). If I manage to properly run one example (I am building now a case for the V-Catchment problem, which has an analytical solution) I will try to develop a version for a triangulation (Liu et al, 2018) or for generic control volumes (Beljadid et al, 2016). Thanks a lot Jac

Jacob Bensabat, Ph.D. EWRE Ltd. 3, Shaar Halevanon Street Haifa – 3445402 Israel. Tel: +972-4-8383919 Mobile: +972-544417511 [EWRELogoNew]

From: Byron Tasseff notifications@github.com Sent: Wednesday, July 29, 2020 6:37 AM To: lanl/nuflood nuflood@noreply.github.com Cc: Jbensabat jbensabat@ewre.com; Mention mention@noreply.github.com Subject: Re: [lanl/nuflood] Documentation and examples (#3)

@jbensabathttps://github.com/jbensabat, sorry for the delay! I will try to add a rainfall-runoff example to this repository over the weekend.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/lanl/nuflood/issues/3#issuecomment-665411729, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZNJ2D7OLNDV3DQQEW6ZC3R56KPTANCNFSM4M7XY7YQ.

tasseff commented 4 years ago

@jbensabat, a couple updates. First, I've added a a description of the JSON input fields to DATA.md. Second, I've created an extension repository, nuflood-examples that currently includes a very simple rainfall scenario over a flat surface. I will investigate the addition more complex scenarios, but I hope this is enough to get you started. However, again, the time I can devote to maintaining this project is very limited at the moment, so I cannot promise much.

Your proposal to implement a non-rectangular discretization is interesting. However, I will warn that there would likely be a lot of development effort involved in something like that if you are planning to use the current version of Nuflood as a foundation. The existing I/O routines and models rely quite extensively on the assumption of a rectangular discretization.

tasseff commented 4 years ago

Also, absolutely feel free to continue posting additional issues and questions here. I am happy to help.

jbensabat commented 4 years ago

Hello and thank you very much for your help. I think that on the basis of the example I will be able to get a hold on the code and from there it will be much easier to run additional cases. With regard to the extension to irregular grids, we have a mesh generator producing CDT (constrained Delaunay triangulation) and CVD (constrained Voronoi diagram) so I think that we would need to add a computational mesh to the code together with boundary conditions and interpolate from the DEMs onto the grids. It may take a while because this is not our main activity but I’ll start doing it once I can run a couple of examples and get confidence. In any case thank you very much for your support. Jac

Jacob Bensabat, Ph.D. EWRE Ltd. 3, Shaar Halevanon Street Haifa – 3445402 Israel. Tel: +972-4-8383919 Mobile: +972-544417511 [EWRELogoNew]

From: Byron Tasseff notifications@github.com Sent: Sunday, August 2, 2020 3:29 AM To: lanl/nuflood nuflood@noreply.github.com Cc: Jbensabat jbensabat@ewre.com; Mention mention@noreply.github.com Subject: Re: [lanl/nuflood] Documentation and examples (#3)

@jbensabathttps://github.com/jbensabat, a couple updates. First, I've added a a description of the JSON input fields to DATA.mdhttps://github.com/lanl/nuflood/blob/master/DATA.md. Second, I've created an extension repository, nuflood-exampleshttps://github.com/tasseff/nuflood-examples that currently includes a very simple rainfall scenario over a flat surface. I will investigate the addition more complex scenarios, but I hope this is enough to get you started. However, again, the time I can devote to maintaining this project is very limited at the moment, so I cannot promise much.

Your proposal to implement a non-rectangular discretization is interesting. However, I will warn that there would likely be a lot of development effort involved in something like that if you are planning to use the current version of Nuflood as a foundation. The existing I/O routines and models rely quite extensively on the assumption of a rectangular discretization.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/lanl/nuflood/issues/3#issuecomment-667604900, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZNJ2CU762DPH4PRQMZSITR6SXMBANCNFSM4M7XY7YQ.

tasseff commented 4 years ago

Also, for clarity, I've migrated the examples project to this link (https://github.com/lanl/nuflood-examples). This is different than my initial message, which I've now edited.

jbensabat commented 4 years ago

Thanks Jac

Jacob Bensabat, Ph.D. EWRE Ltd. 3, Shaar Halevanon Street Haifa – 3445402 Israel. Tel: +972-4-8383919 Mobile: +972-544417511 [EWRELogoNew]

From: Byron Tasseff notifications@github.com Sent: Sunday, August 2, 2020 9:06 AM To: lanl/nuflood nuflood@noreply.github.com Cc: Jbensabat jbensabat@ewre.com; Mention mention@noreply.github.com Subject: Re: [lanl/nuflood] Documentation and examples (#3)

Also, for clarity, I've migrated the examples project to this link (https://github.com/lanl/nuflood-examples). This is different than my initial message, which I've now edited.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/lanl/nuflood/issues/3#issuecomment-667633501, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AAZNJ2DFNKYOEEFSIX3GM2DR6T66FANCNFSM4M7XY7YQ.