search

lanl / palm_lanl

LANL Contributions to PArallelized Large-eddy simulation Model (PALM)
2 stars 5 forks source link

Bugfix for tke buoyancy production #54

Closed cbegeman closed 4 years ago

cbegeman commented 4 years ago

This PR provides a bugfix whereby TKE buoyancy production at the surface was off by a factor of rho_ocean. It also changes a few check_parameters conflicts from aborts to warnings, indicating which namelist option gets precedence.

cbegeman commented 4 years ago

@vanroekel Can you take a look at a294891? My goal was to just build on your branch to output the horizontal buoyancy fluxes as well. I'm getting zeros for u*sa* and v*sa* fields in the netCDF file. Maybe because you just examined this routine you'll be able to tell what I'm missing. Thanks!

vanroekel commented 4 years ago

I wonder if it could be L1589 of flow statistics. It says if (not ws_scheme_sca). We normally run with ws_sceme on, so I wonder if this part of the code is never called. Do you have a corresponding calculations in advec_ws.f90 to compute upt and usa? Not sure if that is the issue, but that's the only thing that jumps out at me.

cbegeman commented 4 years ago

@vanroekel Good point. That was the issue. Of course, I was looking for something more complex than necessary. This will be set to merge once we're happy with your PR https://github.com/xylar/palm_les_lanl/pull/52.

cbegeman commented 4 years ago

@vanroekel I'd like to get this bugfix into master. I moved the commit related to outputting additional tke budget terms to a new branch, which we'll merge after https://github.com/xylar/palm_les_lanl/pull/52. Let me know when I can merge this PR.

vanroekel commented 4 years ago

@cbegeman feel free to merge when you are ready. Thanks for picking this into a separate PR.