search

lanoxx / tilda

A Gtk based drop down terminal for Linux and Unix
GNU General Public License v2.0
1.27k stars 162 forks source link

Allow configuring displaying bold text in bright colors #506

Closed arcctgx closed 10 months ago

arcctgx commented 1 year ago

This pull request introduces a checkbox which controls "Bold is bright" VTE option in Tilda (issue #325).

A new checkbox "Show bold text in bright colors" is placed in the UI below "Color Palette" section in "Colors" tab in configuration window. The placement and naming of the checkbox is inspired by similar option in xfce4-terminal and Terminator terminal emulators.

This pull request should also include an update of the translation files, but I'm unsure how to proceed with them. Current .po files seem outdated, and updating them automatically by running make update-po results in a huge change set (about 3700 modified lines). By examining Polish translation, I can see that some of the translations are getting "lost" (gettext moves them to the end of .po file and comments them out). That's happening for other languages as well.

I also tried updating the po/POTFILES.in file (because some of the strings that get commented out are located in files not referenced in this file). While this results in less "lost" translations, I can see that some of the strings are assigned incorrectly in Polish translation. I can only assume it is probably happening elsewhere as well.

If you find the code change acceptable, could you advise how to proceed with the translations?

lanoxx commented 10 months ago

I have merged your pull request, but I will need to look into the translation question separately. I suggest moving that part into a new issue so that it does not get lost, since this pull request is now closed.

arcctgx commented 10 months ago

Thank you. I opened #508 to track the translations part.