lantus / devilution-nx

Diablo for the Nintendo Switch
The Unlicense
859 stars 61 forks source link

QOL patches #9

Open darthvinyll opened 5 years ago

darthvinyll commented 5 years ago

Hi,

Would this devilution version be compatible with devilutionX patches? Cursory looks seems to suggests so, but wanted to double check. I'm after the autoclick mod specifically, since I do not wish to wear our my controller buttons.

https://github.com/Manuel-K/devilutionX-QOL-patches

AJenbo commented 5 years ago

devilution-nx is based on devilutionX, so should be compatible with the patches.

darthvinyll commented 5 years ago

Just as an update, I went ahead an merged the devilutionX-QOL patches with the NX version. Since they refer to an older version of the devilution codebase, I had to do it manually. As per below, the heath bar functionality for mobs/bosses works well. The sound notification when hitting a new xp level works as well. The running in the town patch is a bit undercooked (the animation looks silly).

The 'attack continuously while holding the attack button' patch focuses on the mouse control method, as opposed to the SDL joystick method found in this NX port. While I was able to re-map the controls to my liking, I was not able to create a working loop using SDL_JOYBUTTONUP as a terminating trigger (the logic was: keep spamming the attack with intervals [to avoid an uncanny dps spike] until the attack button is released).

Anyways, I have settled for an attack trigger upon pressing the attack key down and the another attack trigger upon the button release, which translated for a subjectively smoother gaming experience (avoids extreme button mashing).

2019071409343200-691C9B2C6D1F1E032DDC01FD026159FD

2019071408572100-691C9B2C6D1F1E032DDC01FD026159FD

AJenbo commented 4 years ago

Switch support is now upstreamed so QOL patches should work there out of the box.