search

laravel-doctrine / orm

A drop-in Doctrine ORM 2 implementation for Laravel 5+ and Lumen
http://laraveldoctrine.org
MIT License
823 stars 180 forks source link

[BUG] PrimaryReadReplica doesn't work #560

Open gierappa opened 10 months ago

gierappa commented 10 months ago

Function hasValidPrimaryReadReplicaConfig is a void function throwing only exceptions so if statement does not work.

if ($this->isPrimaryReadReplicaConfigured($driver)) {
    if($this->hasValidPrimaryReadReplicaConfig($driver)) {
        $connection_configuration = (new PrimaryReadReplicaConnection($this->config, $connection_configuration))->resolve($driver);
    }
}

Proposal: 

if ($this->isPrimaryReadReplicaConfigured($driver)) {
    $this->hasValidPrimaryReadReplicaConfig($driver);
    $connection_configuration = (new PrimaryReadReplicaConnection($this->config, $connection_configuration))->resolve($driver);
}