BindingResolutionException since upgrade to 2.1.2

laravel-notification-channels / fcm

Firebase Cloud Messaging (FCM) notifications channel for Laravel

https://laravel-notification-channels.com/

MIT License

495 stars 127 forks source link

BindingResolutionException since upgrade to 2.1.2 #69

Closed dododedodonl closed 3 years ago

dododedodonl commented 3 years ago

When composer auto-upgraded to 2.1.2, notifications on a queue stopped working with this exception:

Illuminate\Contracts\Container\BindingResolutionException: Target [Kreait\Firebase\Project\ProjectId] is not instantiable while building [NotificationChannels\Fcm\FcmChannel, Kreait\Firebase\Messaging].

Downgrading to 2.1.1 solves the problem.

atymic commented 3 years ago

@ankurk91 can you take a look at this? I don't actually use this so unable to test. If no response, I will revert shortly.

ankurk91 commented 3 years ago

I saw this issue when there is no credentials supplied. If we have valid firebase credentials then it works well. i am on laravel 8.15.

Can you specify your laravel version?

PS. Sent a PR to fix this.