search

laravel / horizon

Dashboard and code-driven configuration for Laravel queues.
https://laravel.com/docs/horizon
MIT License
3.88k stars 658 forks source link

[5.x] Upgrade from Vue 2 to Vue 3 #1496

Closed osbre closed 2 months ago

osbre commented 2 months ago

Vue 2 has reached EOL. I think it's a good idea to migrate to Vue 3 since there are only a few changes to make it happen:

  1. Update dependencies and Vue initialization in app.js.
  2. Remove redundant/unused addTagModalClosed event dispatching due to the event bus being deprecated and the event itself being unused by Horizon.
  3. Reorganize the routes as nested so they still highlight as active in the sidebar due to the change in vue-router v4 active link logic.

I have tested the app and it works perfectly fine as before. Vue 3 💚

github-actions[bot] commented 2 months ago

Thanks for submitting a PR!

Note that draft PR's are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface.

Pull requests that are abandoned in draft may be closed due to inactivity.